linux-kernel - Re: [patch] fix up generic csum_ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p73y7qf3cxs.fsf@bingen.suse.de>
Date:	13 Nov 2006 10:37:03 +0100
From:	Andi Kleen <ak@...e.de>
To:	Al Viro <viro@....linux.org.uk>
Cc:	kenneth.w.chen@...el.com, akpm@...l.org, jgarzik@...ox.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [patch] fix up generic csum_ipv6_magic function prototype

Al Viro <viro@....linux.org.uk> writes:
> 
> Incidentally, WTF is
> define SK_CS_CALCULATE_CHECKSUM
> #ifndef CONFIG_X86_64
> #define SkCsCalculateChecksum(p,l)      ((~ip_compute_csum(p, l)) & 0xffff)
> #else
> #define SkCsCalculateChecksum(p,l)      ((~ip_fast_csum(p, l)) & 0xffff)   
> #endif
> in ./drivers/net/sk98lin/h/skdrv1st.h?

Looks totally bogus. The x86-64 ip_fast_csum is practically identical
to the i386 version. Someone must have been asleep while reviewing
that code.

But AFAIK sk98lin is scheduled for deletion anyways, to be replaced by 
sky*. Probably for good reasons. Hopefully soon.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/