linux-kernel - Re: [patch] fix up generic csum_ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20061113.161656.90118004.davem@davemloft.net>
Date:	Mon, 13 Nov 2006 16:16:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	viro@....linux.org.uk
Cc:	kenneth.w.chen@...el.com, akpm@...l.org, jgarzik@...ox.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [patch] fix up generic csum_ipv6_magic function prototype

From: Al Viro <viro@....linux.org.uk>
Date: Mon, 13 Nov 2006 08:52:23 +0000

> The first question is in the types we are using for length.  OK,
> csum_tcpudp_...() is a special case; there we want u16 and unless
> there's a reason _not_ to do so on sparc, I'd rather convert it
> to the same thing.

That's fine.

> csum_partial_copy_fromuser():  Can die, only 3 targets have its rudiment
> and nothing in the tree uses it.  ACK?

ACK.

> csum_partial_copy().  Rare alias for csum_partial_copy_nocheck().  Can die;
> all instances simply should be renamed to csum_partial_copy_nocheck.  ACK?

ACK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/