linux-kernel - Re: [RFC] [PATCH 10/16] x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Nov 2006 00:43:34 +0100
From:	Pavel Machek <pavel@....cz>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Vivek Goyal <vgoyal@...ibm.com>,
	linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Reloc Kernel List <fastboot@...ts.osdl.org>, akpm@...l.org,
	ak@...e.de, hpa@...or.com, magnus.damm@...il.com, lwang@...hat.com,
	dzickus@...hat.com
Subject: Re: [RFC] [PATCH 10/16] x86_64: 64bit PIC ACPI wakeup

Hi!

> >> I don't have a configuration I can test this but it compiles cleanly
> >
> > Ugh, now that's a big patch.. and untested, too :-(.
> 
> It was very carefully code reviewed at least the first time,
> and the code was put in sync with code that was tested.

So we had two very different versions of "switch to 64-bit" and now we
have two mostly similar versions. Not a big improvement...

> > Why is PGE no longer required, for example?
> 
> PGE is never required.  Especially on a temporary page table.
> PGE is an optimization, to make context switches faster.

HPA tells me it is.

> > Can we get it piece-by-piece?

Please?

> >> Vivek has tested this patch for suspend to memory and it works fine.
> >
> > Ok, so it was tested on one config. Given that the patch deals with
> > detecting CPU oddities... :-(
> 
> Read the code.  Given your scorn and the state of that mess when I
> started I'm not certain a productive conversation can be had.
> 
> Do you understand the code as it is currently written?

Mostly. I've written it at some point.

It may be a mess, but patch below is wholesale rewrite, mixing
cleanups (ebx->rbx) with serious changes (PGE). And then you tell me
it was tested on one machine. It is hard/impossible to rewrite, and
changelog is not helpful, either.

Please split it up.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/