linux-kernel - Re: [PATCH]: HVCS char driver janitoring: fix compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061116203946.GA23600@austin.ibm.com>
Date:	Thu, 16 Nov 2006 14:39:46 -0600
From:	linas@...tin.ibm.com (Linas Vepstas)
To:	Michael Ellerman <michael@...erman.id.au>
Cc:	Greg KH <greg@...ah.com>, akpm@...l.org,
	Alan Cox <alan@...hat.com>, "Ryan S. Arnold" <rsa@...ibm.com>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: HVCS char driver janitoring: fix compile warnings

On Thu, Nov 16, 2006 at 11:03:07AM +1100, Michael Ellerman wrote:
> On Wed, 2006-11-15 at 15:26 -0600, Linas Vepstas wrote:
> > 
> > This is a non-urgent patch. 
> > 
> > I can't figure out who the upstream maintainer for char drivers 
> > is supposed to be. Can this patch be applied? 
> > 
> > --linas
> > 
> > This patch removes an pair of irritating compiler warnings:
> > 
> > drivers/char/hvcs.c:1605: warning: ignoring return value of
> > sysfs_create_group declared with attribute warn_unused_result
> > drivers/char/hvcs.c:1639: warning: ignoring return value of
> > driver_create_file declared with attribute warn_unused_result
> > 
> > Doing this required moving a big block of code from the bottom 
> > of the file to the top, so as to avoid the need for (irritating) 
> > forward declarations.
> 
> Can you do the move and the fix as two patches? It's very hard to review
> in its current form.

Sorry, coming shortly. -- linas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/