linux-kernel - Re: [PATCH]: HVCS char driver janitoring: fix compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1163716536.16815.5.camel@localhost.localdomain>
Date:	Fri, 17 Nov 2006 09:35:36 +1100
From:	Michael Ellerman <michael@...erman.id.au>
To:	Linas Vepstas <linas@...tin.ibm.com>
Cc:	Greg KH <greg@...ah.com>, akpm@...l.org,
	Alan Cox <alan@...hat.com>, "Ryan S. Arnold" <rsa@...ibm.com>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: HVCS char driver janitoring: fix compile warnings

On Thu, 2006-11-16 at 14:39 -0600, Linas Vepstas wrote:
> On Thu, Nov 16, 2006 at 11:03:07AM +1100, Michael Ellerman wrote:
> > On Wed, 2006-11-15 at 15:26 -0600, Linas Vepstas wrote:
> > > 
> > > This is a non-urgent patch. 
> > > 
> > > I can't figure out who the upstream maintainer for char drivers 
> > > is supposed to be. Can this patch be applied? 
> > > 
> > > --linas
> > > 
> > > This patch removes an pair of irritating compiler warnings:
> > > 
> > > drivers/char/hvcs.c:1605: warning: ignoring return value of
> > > sysfs_create_group declared with attribute warn_unused_result
> > > drivers/char/hvcs.c:1639: warning: ignoring return value of
> > > driver_create_file declared with attribute warn_unused_result
> > > 
> > > Doing this required moving a big block of code from the bottom 
> > > of the file to the top, so as to avoid the need for (irritating) 
> > > forward declarations.
> > 
> > Can you do the move and the fix as two patches? It's very hard to review
> > in its current form.
> 
> Sorry, coming shortly. -- linas

Thanks, new patches look good.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)