linux-kernel - Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200611162246.21018.dtor@insightbb.com>
Date:	Thu, 16 Nov 2006 22:46:18 -0500
From:	Dmitry Torokhov <dtor@...ightbb.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	David Miller <davem@...emloft.net>, jesper.juhl@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???

On Thursday 16 November 2006 19:37, Herbert Xu wrote:
> David Miller <davem@...emloft.net> wrote:
> >
> > I'm very happy to accept a patch which assert's this using BUG()
> > checks :-)
> 
> A BUG() won't be necessary because the NULL pointer dereferences will
> OOPS anyway.
>

BUG()s there would be a mechanism to document invariants so next time
someone is looking at the code there are no questions.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/