linux-kernel - Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1GkwGq-0004tw-00@gondolin.me.apana.org.au>
Date:	Fri, 17 Nov 2006 16:28:12 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	dtor@...ightbb.com (Dmitry Torokhov)
Cc:	herbert@...dor.apana.org.au, davem@...emloft.net,
	jesper.juhl@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???

Dmitry Torokhov <dtor@...ightbb.com> wrote:
> 
> BUG()s there would be a mechanism to document invariants so next time
> someone is looking at the code there are no questions.

Well if someone is documenting this then wouldn't a comment (or even a
kerneldoc style block) be better?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/