linux-kernel - Re: [patch/rfc 2.6.19-rc5] arch-neutral GPIO calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200611201415.19095.david-b@pacbell.net>
Date:	Mon, 20 Nov 2006 14:15:17 -0800
From:	David Brownell <david-b@...bell.net>
To:	Linux Kernel list <linux-kernel@...r.kernel.org>
Cc:	Andrew Morton <akpm@...l.org>,
	Andrew Victor <andrew@...people.com>,
	Bill Gatliff <bgat@...lgatliff.com>,
	Haavard Skinnemoen <hskinnemoen@...el.com>, jamey.hicks@...com,
	Kevin Hilman <khilman@...sta.com>,
	Nicolas Pitre <nico@....org>,
	Russell King <rmk@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>,
	Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [patch/rfc 2.6.19-rc5] arch-neutral GPIO calls

OK, just trying to summarize here:

 - Nobody has reported **ANY** real problem with the API, other than a minor
   comment from Andrew Victor about a must_check annotation (resolved in a
   nyet-posted update).  No surprise; there are already nearly a dozen APIs
   in the kernel doing exactly the same thing.

 - Various folk want to see an additional API that can work with things like
   I2C GPIO expanders ... where the bit get/set calls require task contexts.
   Everyone agrees such a thing is eventually needed, but nobody needs it
   "today".

 - There's interest in a userspace interface to GPIOs; nothing pressing, and
   that's at a different level, but worth noting since it always comes up.

 - Paul Mundt also wants to see pin muxing APIs.  Fine, but that's both
   orthogonal and highly platform-specific.  I can't support trying to
   merge it into the generic notion of a GPIO line.

 - Paul also wants to see implementations package multiple sync/atomic GPIO
   controllers using this API.  The API that I pulled together clearly permits
   implementations to do that ... but it does not require them to do so.

I could certainly take all that feedback and let it lead me to some particular
implementation -- example, a table of { controller, index, flags } structs indexed
by the GPIO numbers, with controller ops vectors matching the primitives -- but
even if that were to happen, I'd like to know if anyone has any major disagreement
with the summary above.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/