linux-kernel - [patch 2.6.19-rc6 1/6] rtc class /proc/driver/rtc update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200611201017.19961.david-b@pacbell.net>
Date:	Mon, 20 Nov 2006 10:17:19 -0800
From:	David Brownell <david-b@...bell.net>
To:	Alessandro Zummo <alessandro.zummo@...ertech.it>
Cc:	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: [patch 2.6.19-rc6 1/6] rtc class /proc/driver/rtc update

Fix two minor botches in the procfs dumping of RTC alarm status:

 - Stop confusing "alarm enabled" with "wakeup enabled".

 - Don't display bogus "irq pending/un-acked" status; those are the rather
   pointless semantics EFI assigned to this (for a no-IRQs environment).

The main RTC that seems confused about this is the sa1100 one, which
doesn't actually report whether it enabled the alarm.

Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>

Index: g26/drivers/rtc/rtc-proc.c
===================================================================
--- g26.orig/drivers/rtc/rtc-proc.c	2006-11-20 09:35:39.000000000 -0800
+++ g26/drivers/rtc/rtc-proc.c	2006-11-20 09:36:23.000000000 -0800
@@ -66,9 +66,11 @@ static int rtc_proc_show(struct seq_file
 		else
 			seq_printf(seq, "**\n");
 		seq_printf(seq, "alrm_wakeup\t: %s\n",
+				device_may_wakeup(class_dev->dev)
+					? "yes" : "no");
+		seq_printf(seq, "alrm_enabled\t: %s\n",
 				alrm.enabled ? "yes" : "no");
-		seq_printf(seq, "alrm_pending\t: %s\n",
-				alrm.pending ? "yes" : "no");
+		/* alrm.pending ("irq un-acked") is useless ... */
 	}
 
 	seq_printf(seq, "24hr\t\t: yes\n");
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/