linux-kernel - Re: [RFC][PATCH] Fix locking on misrouted interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 21 Nov 2006 21:26:00 +0100
From:	Ingo Molnar <mingo@...hat.com>
To:	Pavel Emelianov <xemul@...nvz.org>
Cc:	Vivek Goyal <vgoyal@...ibm.com>, Andrew Morton <akpm@...l.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kirill Korotaev <dev@...ru>
Subject: Re: [RFC][PATCH] Fix locking on misrouted interrupts

On Tue, 2006-11-21 at 11:48 +0300, Pavel Emelianov wrote:
> Vivek noted that many places call note_interrupt()
> without desc->lock being held. Since note_interrupt()
> which tries to unlock this lock to handle spurious
> interrupts accodring to
> http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f72fa707604c015a6625e80f269506032d5430dc
> 
> Looking at note_interrupt() I found that desc->lock
> IS required in this function but all the places that
> call note_interrupt() lock it after the call. One
> exception from this rule is __do_IRQ().
> 
> So I move spin_lock(&desc->lock); before calling
> note_interrupt() in all places.
> 
> Signed-off-bt: Pavel Emelianov <xemul@...nvz.org>

indeed - and this is a fallout of the earlier fix in note_interrupt().
Andrew, Linus: i think this is a must-have for 2.6.19 as well.

Acked-by: Ingo Molnar <mingo@...hat.com>

	Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/