linux-kernel - [RFC][PATCH] Fix locking on misrouted interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4562BD4E.20600@openvz.org>
Date:	Tue, 21 Nov 2006 11:48:14 +0300
From:	Pavel Emelianov <xemul@...nvz.org>
To:	Vivek Goyal <vgoyal@...ibm.com>, Ingo Molnar <mingo@...hat.com>,
	Andrew Morton <akpm@...l.org>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kirill Korotaev <dev@...ru>
Subject: [RFC][PATCH] Fix locking on misrouted interrupts

Vivek noted that many places call note_interrupt()
without desc->lock being held. Since note_interrupt()
which tries to unlock this lock to handle spurious
interrupts accodring to
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f72fa707604c015a6625e80f269506032d5430dc

Looking at note_interrupt() I found that desc->lock
IS required in this function but all the places that
call note_interrupt() lock it after the call. One
exception from this rule is __do_IRQ().

So I move spin_lock(&desc->lock); before calling
note_interrupt() in all places.

Signed-off-bt: Pavel Emelianov <xemul@...nvz.org>

View attachment "diff-note-interrupt-locking-fix" of type "text/plain" (2094 bytes)