linux-kernel - Re: [PATCH 4/5] e1000 : Make Intel e1000 driver legacy I/O port free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Nov 2006 08:11:28 -0800
From:	Auke Kok <auke-jan.h.kok@...el.com>
To:	Matthew Wilcox <matthew@....cx>
CC:	Arjan van de Ven <arjan@...radead.org>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-pci@...ey.karlin.mff.cuni.cz, Greg KH <greg@...ah.com>,
	Grant Grundler <grundler@...isc-linux.org>,
	Andrew Morton <akpm@...l.org>,
	e1000-devel@...ts.sourceforge.net, linux-scsi@...r.kernel.org,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
Subject: Re: [PATCH 4/5] e1000 : Make Intel e1000 driver legacy I/O port free

Matthew Wilcox wrote:
> On Wed, Nov 22, 2006 at 09:56:49AM +0100, Arjan van de Ven wrote:
>> On Wed, 2006-11-22 at 17:06 +0900, Hidetoshi Seto wrote:
>>>  static struct pci_device_id e1000_pci_tbl[] = {
>>> +	INTEL_E1000_ETHERNET_DEVICE(0x1004, 0),
>>> +	INTEL_E1000_ETHERNET_DEVICE(0x1008, E1000_USE_IOPORT),
>> Hi,
>>
>> this has the unfortunate effect that it's now a lot harder to add PCI
>> ID's to this driver at runtime via sysfs ;(
> 
> It does?  Normally you get 0 passed in that field, so you'll just not
> get io ports enabled ...
> 
> Need to set use_driver_data to get non-0 passed in that field.

I think we want to condense the USE_IOPORT flag together with the other hardware feature 
flags, as suggested by Jeff Garzik. This would save some headroom and leave the pci 
device id table as it is.

Cheers,

Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/