linux-kernel - Re: [PATCH] x86_64: fix build without HOTPLUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061123152734.GG29738@bingen.suse.de>
Date:	Thu, 23 Nov 2006 16:27:34 +0100
From:	Andi Kleen <ak@...e.de>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Andi Kleen <ak@...e.de>, linux-kernel@...r.kernel.org,
	Reuben Farrelly <reuben-linuxkernel@...b.net>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] x86_64: fix build without HOTPLUG_CPU (was Re: 2.6.19-rc6-mm1)

On Thu, Nov 23, 2006 at 04:17:00PM +0100, Jiri Kosina wrote:
> On Thu, 23 Nov 2006, Andi Kleen wrote:
> 
> > > cpu_vsyscall_notifier() is defined only when CONFIG_HOTPLUG_CPU is 
> > > defined.
> > It's already long fixed in Linus' tree (in 
> > 6b3d1a95ba714bfb1cc81362f7f3e01b7654b4f3) I wonder why that didn't 
> > makeit into Andrew's. Andrew, time to update your linus-patch?
> 
> Well, is it really? 6b3d1a95ba714bfb1cc81362f7f3e01b7654b4f3 adds the 
> ifdef around the cpu_vsyscall_notifier() declaration, but later it's 
> passed as parameter to hotcpu_notifier() unconditionally. This is fixed by 
> the patch I sent.

hotcpu_notifier is a macro that expands to nothing for !CONFIG_HOTPLUG_CPU

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/