linux-kernel - Re: [patch 5/5] [RFC] Add MMC Password Protection (lock/unlock) support V7: mmc_omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <456805F3.1020407@drzeus.cx>
Date:	Sat, 25 Nov 2006 09:59:31 +0100
From:	Pierre Ossman <drzeus-list@...eus.cx>
To:	Anderson Briglia <anderson.briglia@...t.org.br>
CC:	"Linux-omap-open-source@...ux.omap.com" 
	<linux-omap-open-source@...ux.omap.com>,
	Russell King <rmk+lkml@....linux.org.uk>,
	Tony Lindgren <tony@...mide.com>,
	"Aguiar Carlos (EXT-INdT/Manaus)" <carlos.aguiar@...t.org.br>,
	ext David Brownell <david-b@...bell.net>,
	"Lizardo Anderson (EXT-INdT/Manaus)" <anderson.lizardo@...t.org.br>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 5/5] [RFC] Add MMC Password Protection (lock/unlock) support
 V7: mmc_omap_dma.diff

Anderson Briglia wrote:
> OMAP platform specific patch.
> - Adjust the frame size for DMA transfers.
>
> Signed-off-by: Anderson Briglia <anderson.briglia <at> indt.org.br>
> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar <at> indt.org.br>
>

This looks like a generic patch for OMAP and shouldn't be in this set.

> Index: linux-omap-2.6.git/drivers/mmc/omap.c
> ===================================================================
> --- linux-omap-2.6.git.orig/drivers/mmc/omap.c    2006-11-22
> 09:07:25.000000000 -0400
> +++ linux-omap-2.6.git/drivers/mmc/omap.c    2006-11-22
> 09:19:03.000000000 -0400
> @@ -629,6 +629,14 @@ mmc_omap_prepare_dma(struct mmc_omap_hos
>
>      data_addr = host->phys_base + OMAP_MMC_REG_DATA;
>      frame = data->blksz;
> +
> +#ifdef CONFIG_MMC_PASSWORDS
> +    /* MMC LOCK/UNLOCK: Do frame size multiple of two. This is
> +     * needed for DMA transfers to work properly, once
> +     * the block size depends on MMC password length.
> +     */
> +    frame += frame&0x1;
> +#endif
>      count = sg_dma_len(sg);
>
>      if ((data->blocks == 1) && (count > (data->blksz)))
>

Now this you're going to have to explain to me. Especially the part
where why this is specific to the lock commands.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/