lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Nov 2006 19:57:07 +0100 From: Andi Kleen <ak@...e.de> To: Linus Torvalds <torvalds@...l.org> Cc: Ingo Molnar <mingo@...e.hu>, Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org Subject: Re: [patch] x86_64: fix earlyprintk=...,keep regression > > Or is there some reason you really _want_ "keep" to be different? If so, > it should probably be commented on. It's just that keep is the only option that can only be at the end, all others can be followed by more, so it made minor sense to use strcmp() to match the \0 too. But using strncmp everywhere is fine too since the syntax checking on these things is always quite weak and it probably doesn't make much difference either way. I would have gone with Ingo's fix, but if you prefer strncmp..? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists