linux-kernel - Re: [patch] x86_64: fix earlyprintk=...,keep regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061128195653.GA24577@elte.hu>
Date:	Tue, 28 Nov 2006 20:56:53 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...l.org>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...e.de>
Subject: Re: [patch] x86_64: fix earlyprintk=...,keep regression


* Linus Torvalds <torvalds@...l.org> wrote:

> -	if (!strcmp(buf,"keep"))
> +	if (!strncmp(buf,"keep", 4)) {
>  		keep_early = 1;
> -
> -	if (!strncmp(buf, "serial", 6)) {
> +	} else if (!strncmp(buf, "serial", 6)) {
>  		early_serial_init(buf + 6);
>  		early_console = &early_serial_console;

nope, that doesnt work, because the function call is a one-time thing 
via the early_console_initialized flag. Nor does this keep compatibility 
with the 2.6.18 API, my existing boot-entries:

        root (hd0,4)
        kernel /boot/bzImage-x64 root=/dev/hda5 \
	earlyprintk=serial,ttyS0,115200,keep console=ttyS0,115200 console=tty

stopped working.

I agree that the parameter parsing here is a bit hacky, but my patch 
restores the original behavior, so i think that's the best option for 
now.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/