linux-kernel - Re: [PATCH] tlclk: fix platform_device_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061128060830.GA28689@APFDCB5C>
Date:	Tue, 28 Nov 2006 15:08:30 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Mark Gross <mgross@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Sebastien Bouchard <sebastien.bouchard@...kontron.com>,
	akpm@...l.org
Subject: Re: [PATCH] tlclk: fix platform_device_register_simple() error check

On Mon, Nov 27, 2006 at 12:34:52PM -0800, Mark Gross wrote:
> >  
> >  	tlclk_device = platform_device_register_simple("telco_clock",
> >  				-1, NULL, 0);
> > -	if (!tlclk_device) {
> > +	if (IS_ERR(tlclk_device)) {
> ok
> 
> >  		printk(KERN_ERR "tlclk: platform_device_register failed.\n");
> > -		ret = -EBUSY;
> > +		ret = PTR_ERR(tlclk_device);
> 
> I don't know about this but I could be wrong.  Please convince me.

We expect platform_device_register_simple() returns proper errno as pointer
when it fails.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/