linux-kernel - Re: PREEMPT is messing with everyone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4575A53E.8030403@stud.feec.vutbr.cz>
Date:	Tue, 05 Dec 2006 17:58:38 +0100
From:	Michal Schmidt <xschmi00@...d.feec.vutbr.cz>
To:	Jaswinder Singh <jaswinderrajput@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: PREEMPT is messing with everyone

Jaswinder Singh skrev:
> Yes, Compiler will remove it but this looks ugly and confusing.
> 
> Why dont we use like this :-
> 
> #ifdef CONFIG_PREEMPT
> #include <linux/preempt.h>
> #endif
> 
> #ifdef CONFIG_PREEMPT
>  preempt_disable();
> #endif
> 
> #ifdef CONFIG_PREEMPT
>  preempt_enable();
> #endif

Surely you're joking.
It is much more readable and maintainable to hide the #ifdef-hackery in 
header files than to clutter the *.c files.

Michal

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/