linux-kernel - Re: [PATCH 22/35] Unionfs: Lookup helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0612052228550.18570@yvahk01.tjqt.qr>
Date:	Tue, 5 Dec 2006 22:29:53 +0100 (MET)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	"Josef 'Jeff' Sipek" <jsipek@...sunysb.edu>
cc:	linux-kernel@...r.kernel.org, torvalds@...l.org, akpm@...l.org,
	hch@...radead.org, viro@....linux.org.uk,
	linux-fsdevel@...r.kernel.org, mhalcrow@...ibm.com
Subject: Re: [PATCH 22/35] Unionfs: Lookup helper functions


>+/* allocate new dentry private data, free old one if necessary */
>+int new_dentry_private_data(struct dentry *dentry)
>+{
>[...]
>+
>+	spin_unlock(&dentry->d_lock);
>+	return 0;
>+	/* */
>+
>+out_free:
>+	kfree(info->lower_paths);
>+
>+out:
>+	free_dentry_private_data(info);
>+	dentry->d_fsdata = NULL;
>+	spin_unlock(&dentry->d_lock);
>+	return -ENOMEM;
>+}

Whereever I go, ... care to explain the /* */? If it was just a marker
logically belonging to the syntactic sugar, it's missing in the other source
files too.


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/