linux-kernel - Re: [PATCH 23/35] Unionfs: Main module functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Dec 2006 22:32:45 +0100 (MET)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	"Josef 'Jeff' Sipek" <jsipek@...sunysb.edu>
cc:	linux-kernel@...r.kernel.org, torvalds@...l.org, akpm@...l.org,
	hch@...radead.org, viro@....linux.org.uk,
	linux-fsdevel@...r.kernel.org, mhalcrow@...ibm.com
Subject: Re: [PATCH 23/35] Unionfs: Main module functions


>+++ b/fs/unionfs/main.c
>+static int init_debug = 0;
>+module_param_named(debug, init_debug, int, S_IRUGO);
>+MODULE_PARM_DESC(debug, "Initial Unionfs debug value.");

I think there is not anything that forbids it being S_IRUGO | S_IWUSR.


>+
>+static int __init init_unionfs_fs(void)
>+{
>+	int err;
>+	printk("Registering unionfs " UNIONFS_VERSION "\n");
>+
>+	if ((err = init_filldir_cache()))
>+		goto out;
>+	if ((err = init_inode_cache()))
>+		goto out;
>+	if ((err = init_dentry_cache()))
>+		goto out;
>+	if ((err = init_sioq()))
>+		goto out;
>+	err = register_filesystem(&unionfs_fs_type);
>+out:
>+	if (err) {
>+		fin_sioq();
>+		destroy_filldir_cache();
>+		destroy_inode_cache();
>+		destroy_dentry_cache();
>+	}
>+	return err;
>+}
>+static void __exit exit_unionfs_fs(void)
>+{

There's that missing white line again :^)

>+	fin_sioq();
>+	destroy_filldir_cache();
>+	destroy_inode_cache();
>+	destroy_dentry_cache();
>+	unregister_filesystem(&unionfs_fs_type);
>+	printk("Completed unionfs module unload.\n");
>+}
>+
>+MODULE_AUTHOR("Erez Zadok, Filesystems and Storage Lab, Stony Brook University"
>+		" (http://www.fsl.cs.sunysb.edu)");
>+MODULE_DESCRIPTION("Unionfs " UNIONFS_VERSION
>+		" (http://www.unionfs.org)");
>+MODULE_LICENSE("GPL");
>+
>+module_init(init_unionfs_fs);
>+module_exit(exit_unionfs_fs);

Like with sioq, unionfs_init/unionfs_exit should suffice.


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/