linux-kernel - cmpxchg() in kernel/workqueue.c breaks things

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061207.000950.28414823.davem@davemloft.net>
Date:	Thu, 07 Dec 2006 00:09:50 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dhowells@...hat.com
CC:	viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org,
	akpm@...l.org
Subject: cmpxchg() in kernel/workqueue.c breaks things

David, you have to fix the locking scheme used in kernel/workqueue.c,
you absolutely cannot assume that cmpxchg() is available on all
platforms.  This breaks the build on the platforms that don't
have such an instruction, and no it cannot emulated.

Also, because Alan Cox's machine (zeniv) went down, a few folks such
as Al Viro (CC:'d) had no opportunity to comment on your changes
before they went in.  This mess would have been avoided if Al had a
chance to read over this, in particular since he does cross sparc32
builds he knows that cmpxchg is not available there.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/