| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20061207082332.GK4587@ftp.linux.org.uk> Date: Thu, 7 Dec 2006 08:23:32 +0000 From: Al Viro <viro@....linux.org.uk> To: David Miller <davem@...emloft.net> Cc: dhowells@...hat.com, viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org, akpm@...l.org Subject: Re: cmpxchg() in kernel/workqueue.c breaks things On Thu, Dec 07, 2006 at 12:09:50AM -0800, David Miller wrote: > > David, you have to fix the locking scheme used in kernel/workqueue.c, > you absolutely cannot assume that cmpxchg() is available on all > platforms. This breaks the build on the platforms that don't > have such an instruction, and no it cannot emulated. > > Also, because Alan Cox's machine (zeniv) went down, a few folks such > as Al Viro (CC:'d) had no opportunity to comment on your changes > before they went in. This mess would have been avoided if Al had a > chance to read over this, in particular since he does cross sparc32 > builds he knows that cmpxchg is not available there. FWIW, the *real* problem with that (and several other recent breakage incidents) would be avoided if massive cross-arch patchsets would be posted to linux-arch first. It wouldn't catch all crap, but at least it would get folks to check if the damn thing builds. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists