linux-kernel - Re: [PATCH] fs/jfs: fix error due to PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1165615141.8575.7.camel@kleikamp.austin.ibm.com>
Date:	Fri, 08 Dec 2006 15:59:01 -0600
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	Richard Knutsson <ricknu-0@...dent.ltu.se>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Linus Torvalds <torvalds@...l.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/jfs: fix error due to PF_* undeclared

On Fri, 2006-12-08 at 22:29 +0100, Richard Knutsson wrote:
> Randy Dunlap wrote:
> > On Fri, 08 Dec 2006 19:56:20 +0100 Richard Knutsson wrote:

> >> Guess this is the desired fix, since including linux/sched.h in linux/freezer.h
> >> make little sense.
> >>     
> >
> > Why do you say that?  freezer.h is what uses those #defined values,
> > and freezer.h is what uses struct task_struct fields as well,
> > so it needs sched.h.
> >   
> Oh, an error of thought when I read the patch 
> 7dfb71030f7636a0d65200158113c37764552f93 made that statement. After more 
> checking, sched.h is apperarently included in suspend.h from swap.h so 
> the direct include of sched.h in most drivers was/is not nessecary.
> 
> Do you agree with the patch below then? This was how I first fixed it 
> but found it strange no-one hit it before, and from there it went on... 
> Thanks for the help. (Sign it?)

Randy had already submitted a similar patch to lkml.

http://marc.theaimsgroup.com/?l=linux-kernel&m=116561219801397&w=2

> ---
> 
> Compile-tested only.
> 
> 
> diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> index 6e05e3e..f616c0c 100644
> --- a/include/linux/freezer.h
> +++ b/include/linux/freezer.h
> @@ -1,3 +1,4 @@
> +#include <linux/sched.h>
>  /* Freezer declarations */
> 
>  #ifdef CONFIG_PM

Thanks anyway,
Shaggy
-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/