[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1165615416.27217.103.camel@laptopd505.fenrus.org>
Date: Fri, 08 Dec 2006 23:03:36 +0100
From: Arjan van de Ven <arjan@...radead.org>
To: Thomas Hellström <thomas@...gstengraphics.com>
Cc: Dave Jones <davej@...hat.com>, Dave Airlie <airlied@...ux.ie>,
Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [patch 1/2] agpgart - allow user-populated memory types.
On Fri, 2006-12-08 at 19:24 +0100, Thomas Hellström wrote:
>
> +void agp_generic_free_user(struct agp_memory *curr)
> +{
> + if ((unsigned long) curr->memory >= VMALLOC_START
> + && (unsigned long) curr->memory < VMALLOC_END) {
> + vfree(curr->memory);
> + } else {
> + kfree(curr->memory);
> + }
> + agp_free_key(curr->key);
> + kfree(curr);
why? this really is almost too ugly to live ;(
> +}
> +EXPORT_SYMBOL(agp_generic_free_user);
> +
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists