linux-kernel - Re: [patch 1/2] agpgart - allow user-populated memory types.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 08 Dec 2006 23:17:16 +0100
From:	Arjan van de Ven <arjan@...radead.org>
To:	Thomas Hellström <thomas@...gstengraphics.com>
Cc:	Dave Jones <davej@...hat.com>, Dave Airlie <airlied@...ux.ie>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [patch 1/2] agpgart - allow user-populated memory types.

On Fri, 2006-12-08 at 19:24 +0100, Thomas Hellström wrote:
> 
> +       }
> +
> +       if (alloc_size <= PAGE_SIZE) {
> +               new->memory = kmalloc(alloc_size, GFP_KERNEL);
> +       }
> +       if (new->memory == NULL) {
> +               new->memory = vmalloc(alloc_size); 

this bit is more or less evil as well...

1) vmalloc is expensive all the way, higher tlb use etc etc
2) mixing allocation types is just a recipe for disaster
3) if this isn't a frequent operation, kmalloc is fine upto at least 2
pages; I doubt you'll ever want more



-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/