| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 9 Dec 2006 21:50:01 -0500 From: Dmitry Torokhov <dtor@...ightbb.com> To: Randy Dunlap <randy.dunlap@...cle.com> Cc: lkml <linux-kernel@...r.kernel.org>, akpm <akpm@...l.org> Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS On Saturday 09 December 2006 03:36, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@...cle.com> > > This driver is an AC97 codec according to its help text. > However, if SOUND is disabled, the "select SND_AC97_BUS" > still inserts that into the .config file: > > # > # Sound > # > # CONFIG_SOUND is not set > CONFIG_SND_AC97_BUS=m > I consider this abug in kconfig - users of "select" should not know full dependency chain for selected symbol. > Even if the config software followed dependency chains on selects, > we should try to limit usage of "select" to library-type > code that is needed (e.g., CRC functions) instead of bus-type > support. > I do not agree here - the way our directory structure is laid out "sound" comes after "Input device support" menuconfig entry. Your patch makes user go back and forth in menuconfig, which is awkward. I think using select is fine when an option depends on something down the stream. If user already had a chance to select necessary option then using "depends on" is preferred. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists