linux-kernel - Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1165712131.1103.166.camel@localhost.localdomain>
Date:	Sun, 10 Dec 2006 11:55:31 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Andrew Morton <akpm@...l.org>
Cc:	Olivier Galibert <galibert@...ox.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Paul Mackerras <paulus@...ba.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: sysfs file creation result nightmare (WAS radeonfb: Fix
	sysfs_create_bin_file warnings)

> And (ultimately) make the function return void.
> 
> Yes, that's probably a valid approach - we've discussed it before but nobody has
> taken it further.

I would have preferred that approach (with a WARN_ON rather than a BUG
though). On the other hand that would make it slightly harder for the
few cases (if any ?) who actually want something like a "create if it
doesn't exist already" semantic.

I'm a bit worried by the amount of code added by systematic checking of
the results for cases that really should never happen. That's why I
prefer a BUG/WARN type semantic.

Maybe the best is to have the examples like radeonfb actually do the

WARN_ON(sysfs_create_file(...));

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/