linux-kernel - Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17788.50849.140884.507248@cargo.ozlabs.ibm.com>
Date:	Mon, 11 Dec 2006 13:46:57 +1100
From:	Paul Mackerras <paulus@...ba.org>
To:	Olivier Galibert <galibert@...ox.com>
Cc:	Andrew Morton <akpm@...l.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Jean Delvare <khali@...ux-fr.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)

Olivier Galibert writes:

> Hmmm, then why don't you just drop the return value from the creation
> function and BUG() in there is something went wrong.  That would allow
> for better error messages too.

In this instance, BUG would mean that the console text would not ever
show up on the screen, and thus the user would never see the message
nor get any indication what wrong beyond "it failed to boot".

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/