linux-kernel - Re: Mark bitrevX() functions as const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17714.1165846705@redhat.com>
Date:	Mon, 11 Dec 2006 14:18:25 +0000
From:	David Howells <dhowells@...hat.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	David Howells <dhowells@...hat.com>,
	Akinobu Mita <akinobu.mita@...il.com>, torvalds@...l.org,
	akpm@...l.org, linux-kernel@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: Mark bitrevX() functions as const 

Jeff Garzik <jeff@...zik.org> wrote:

> > I'm not sure that's a good idea.  You have to be careful not to cause
> > confusion with ordinary "const".
> 
> It's all in the naming.  You could call it 'purefunc' or somesuch.

No, not "pure".  That's something else.

> __attribute__ is very very ugly, an hinders a quick scan of the function
> prototype, particularly if it has a boatload of other attributes.

Maybe you should do:

	extern __attibute__((x, y, z))
	void function_prototype(...);

Then it doesn't hinder it anywhere near as much as, say:

	extern void __fastcall function_prototype(...);

Besides, emacs lights up __attribute__'s in funky colours to make them easier
to look past:-)

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/