linux-kernel - Re: [patch] net: dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Dec 2006 08:56:05 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Andrew Morton <akpm@...l.org>, David Miller <davem@...emloft.net>,
	alan@...rguk.ukuu.org.uk, lenb@...nel.org,
	linux-kernel@...r.kernel.org, ak@...e.de, torvalds@...l.org
Subject: Re: [patch] net: dev_watchdog() locking fix


* Herbert Xu <herbert@...dor.apana.org.au> wrote:

> > It spits a nasty during bringup
> > 
> > e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection
> > forcedeth.c: Reverse Engineered nForce ethernet driver. Version 0.59.
> > netconsole: device eth0 not up yet, forcing it
> > e1000: eth0: e1000_watchdog: NIC Link is Up 100 Mbps Full Duplex
> > WARNING (!__warned) at kernel/softirq.c:137 local_bh_enable()
> 
> Normally networking isn't invoked with interrupts turned off, but I 
> suppose we don't have a choice here.  This is unique being a place 
> where you can get called with BH on, off, or IRQs off.
> 
> Given that this is only used for printk, the easiest solution is 
> probably just to disable local IRQs instead of BH.

yeah. local_bh_enable() can execute pending softirqs and that warning 
protects us against doing that from within irqs-off sections.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/