linux-kernel - Re: [patch] pipe: Don't oops when pipe filesystem isn't mounted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061211012545.ed945cbd.akpm@osdl.org>
Date:	Mon, 11 Dec 2006 01:25:45 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Al Viro <viro@....linux.org.uk>
Cc:	Andrew MChuck Ebbert <76306.1226@...puserve.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"Linus Torvalds orton <akpm@...l.org>" <torvalds@...l.org>
Subject: Re: [patch] pipe: Don't oops when pipe filesystem isn't mounted

On Mon, 11 Dec 2006 09:21:30 +0000
Al Viro <viro@....linux.org.uk> wrote:

> On Mon, Dec 11, 2006 at 01:13:27AM -0800, Andrew Morton wrote:
> > On Mon, 11 Dec 2006 00:55:57 -0800
> > Andrew Morton <akpm@...l.org> wrote:
> > 
> > > I think the bug really is the running of populate_rootfs() before running
> > > the initcalls, in init/main.c:init().  It's just more sensible to start
> > > running userspace after the initcalls have been run.  Statically-linked
> > > drivers which want to load firmware files will lose.  To fix that we'd need
> > > a new callback.  It could be with a new linker section or perhaps simply a
> > > notifier chain.
> > 
> > hm, actually...  Add two new initcall levels, one for populate_rootfs() and
> > one for things which want to come after it (ie: drivers which want to
> > access the filesytem):
> 
> IMO we should just call pipe (and socket) initialization directly at
> the same level as slab, task, dcache, etc.

spose that would work.  But what other initcall-initialised things are not
yet available when populate_rootfs() runs?

<does  grep _initcall */*.c>
<wonders why anything works at all>

> This is basic stuff needed to get operational kernel.  We could try
> to put that on an additional initcall level, but then we ought to
> take the rest of basic setup there as well.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/