linux-kernel - Re: [PATCH] Get rid of most of the remaining k*alloc() casts.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0612191039190.7558@localhost.localdomain>
Date:	Tue, 19 Dec 2006 10:43:30 -0500 (EST)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
cc:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Get rid of most of the remaining k*alloc() casts.

On Tue, 19 Dec 2006, Jan Engelhardt wrote:

> >  Get rid of the remaining obvious pointer casts of all k[cmz]alloc
> >calls, and do a little whitespace cleanup on the result, based on the
> >CodingStyle file.
>
> >-		struct intmem_allocation* alloc =
> >-		  (struct intmem_allocation*)kmalloc(sizeof *alloc, GFP_KERNEL);
> >+		struct intmem_allocation* alloc =
> >+			kmalloc(sizeof(*alloc), GFP_KERNEL);
>
> At the same time, you could make * alloc -> *alloc when it falls on
> the same line as the kmczalloc cleanup. :)

i'd actually thought of that but, as with previous patches of mine,
it's a trade-off -- the more i try to do at once, the more chance
there is of having the patch rejected for some sort of
incompatibility.

as you may have noticed, i try to write scripts to automate a lot of
this.  this last patch definitely needed more manual work than
previous patches so i was loathe to try to push the envelope -- i
wanted to concentrate on the superfluous casts this time, and leave
other issues for future, well-defined patches.

"bit by bit," that's my motto.  well, that and "life is too short to
drink bad wine."

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/