linux-kernel - Re: [PATCH] Get rid of most of the remaining k*alloc() casts.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64N.0612191116170.19395@attu4.cs.washington.edu>
Date:	Tue, 19 Dec 2006 11:25:48 -0800 (PST)
From:	David Rientjes <rientjes@...washington.edu>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
cc:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Get rid of most of the remaining k*alloc() casts.

On Tue, 19 Dec 2006, Robert P. J. Day wrote:

> diff --git a/include/asm-um/thread_info.h b/include/asm-um/thread_info.h
> index 261e2f4..e43c2dd 100644
> --- a/include/asm-um/thread_info.h
> +++ b/include/asm-um/thread_info.h
> @@ -51,8 +51,7 @@ static inline struct thread_info *current_thread_info(void)
>  }
> 
>  /* thread information allocation */
> -#define alloc_thread_info(tsk) \
> -	((struct thread_info *) kmalloc(THREAD_SIZE, GFP_KERNEL))
> +#define alloc_thread_info(tsk) kmalloc(THREAD_SIZE, GFP_KERNEL))
>  #define free_thread_info(ti) kfree(ti)
> 
>  #endif

This patch breaks all of usermode from the change above.

There's also no reason to avoid other cleanups in the area you're 
changing (and testing) such as moving the asterisk for pointers to the 
variable name, deleting extraneous whitespace, or changing the several 
instances in this patch where kzalloc conversion is appropriate.  If it's 
not done now, it will either be forgotten or another patch on the same 
elaborate scale as this one will need to fix it incrementally.  Given the 
high chance of typos such as the one above in broad patches like this, all 
the changes should be rolled together into one patch that is at least 
inspected before submission by the author.

		David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/