lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20061221194652.GC25249@Krystal>
Date:	Thu, 21 Dec 2006 14:46:52 -0500
From:	Mathieu Desnoyers <compudj@...stal.dyndns.org>
To:	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	Ingo Molnar <mingo@...hat.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Christoph Hellwig <hch@...radead.org>
Cc:	Douglas Niehaus <niehaus@...s.ku.edu>,
	"Martin J. Bligh" <mbligh@...igh.org>, ltt-dev@...fik.org,
	Thomas Gleixner <tglx@...utronix.de>,
	systemtap@...rces.redhat.com
Subject: Re: [Ltt-dev] [PATCH 10/10] local_t : x86_64 : local_add_return

local_add_return should also deal with the removed volatile from local_t.

Inspired from atomic_t modifications : it must use the local_t both as input and
output.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>


--- a/include/asm-x86_64/local.h
+++ b/include/asm-x86_64/local.h
@@ -136,8 +136,8 @@ static __inline__ long local_add_return(
 	long __i = i;
 	__asm__ __volatile__(
 		"xaddq %0, %1;"
-		:"=r"(i)
-		:"m"(l->a.counter), "0"(i));
+		:"+r" (i), "+m" (l->a.counter)
+		: : "memory");
 	return i + __i;
 }
 
-- 
OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ