linux-kernel - [patch] high-res timers: fix APIC event-broadcasting code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 21 Dec 2006 22:26:44 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: [patch] high-res timers: fix APIC event-broadcasting code

Subject: [patch] high-res timers: fix APIC event-broadcasting code
From: Ingo Molnar <mingo@...e.hu>

this patch fixes a bug in the APCI-C3-turns-off-lapic related 
event-broadcasting code: it accidentally reactivated the global tick, 
instead of the global event emulation layer.

The effect of this bug was a rare bootup hang on one of my test-laptops 
- but it could also result in other types of timer related problems (but 
not hangs in an already running system), such as imprecise high-res 
timeouts.

Debugged via SysRq-Q.

Signed-off-by: Ingo Molnar <mingo@...e.hu>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 arch/i386/kernel/apic.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-hres-timers.q/arch/i386/kernel/apic.c
===================================================================
--- linux-hres-timers.q.orig/arch/i386/kernel/apic.c
+++ linux-hres-timers.q/arch/i386/kernel/apic.c
@@ -506,7 +506,7 @@ void switch_APIC_timer_to_ipi(void *cpum
 	int cpu = smp_processor_id();
 
 	if (cpu_isset(cpu, mask) && levt->event_handler)
-		clockevents_set_global_broadcast(levt, 1);
+		clockevents_set_broadcast(levt, 1);
 }
 EXPORT_SYMBOL_GPL(switch_APIC_timer_to_ipi);
 
@@ -517,7 +517,7 @@ void switch_ipi_to_APIC_timer(void *cpum
 	int cpu = smp_processor_id();
 
 	if (cpu_isset(cpu, mask) && levt->event_handler)
-		clockevents_set_global_broadcast(levt, 0);
+		clockevents_set_broadcast(levt, 0);
 }
 EXPORT_SYMBOL_GPL(switch_ipi_to_APIC_timer);
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/