lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <200701021332.19993.m.kozlowski@tuxland.pl>
Date:	Tue, 2 Jan 2007 13:32:19 +0100
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	video4linux-list@...hat.com
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] video: tvmixer module_put cleanup

Hello,

	This patch removes redundant argument check for module_put().
	
Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

 drivers/media/video/tvmixer.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff -upr linux-2.6.20-rc2-mm1-a/drivers/media/video/tvmixer.c linux-2.6.20-rc2-mm1-b/drivers/media/video/tvmixer.c
--- linux-2.6.20-rc2-mm1-a/drivers/media/video/tvmixer.c	2006-12-24 05:00:32.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/drivers/media/video/tvmixer.c	2007-01-02 02:27:41.000000000 +0100
@@ -213,8 +213,7 @@ static int tvmixer_release(struct inode 
 		return -ENODEV;
 	}
 
-	if (client->adapter->owner)
-		module_put(client->adapter->owner);
+	module_put(client->adapter->owner);
 	return 0;
 }
 


-- 
Regards,

	Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ