linux-kernel - [PATCH] fs: proc module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200701021337.15596.m.kozlowski@tuxland.pl>
Date:	Tue, 2 Jan 2007 13:37:15 +0100
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] fs: proc module_put cleanup

Hello,

	This patch removes redundant argument check for module_put().

Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

 fs/proc/inode.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff -upr linux-2.6.20-rc2-mm1-a/fs/proc/inode.c linux-2.6.20-rc2-mm1-b/fs/proc/inode.c
--- linux-2.6.20-rc2-mm1-a/fs/proc/inode.c	2006-12-28 12:57:47.000000000 +0100
+++ linux-2.6.20-rc2-mm1-b/fs/proc/inode.c	2007-01-02 02:25:44.000000000 +0100
@@ -60,8 +60,7 @@ static void proc_delete_inode(struct ino
 	/* Let go of any associated proc directory entry */
 	de = PROC_I(inode)->pde;
 	if (de) {
-		if (de->owner)
-			module_put(de->owner);
+		module_put(de->owner);
 		de_put(de);
 	}
 	clear_inode(inode);


-- 
Regards,

	Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/