linux-kernel - Re: [PATCH 2.6.19] Adding branch to remove possible unnecessary inst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070102083255.GP2483@kernel.dk>
Date:	Tue, 2 Jan 2007 09:32:56 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	yc_zhou <yc_zhou@...c.ac.cn>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH  2.6.19] Adding branch to remove possible unnecessary inst

On Sun, Dec 31 2006, yc_zhou wrote:
> Function blk_queue_bounce_limit using dma flag to determine whether
> assigned a certain value for member of request_queue_t. But the
> assignment is unconditionally after the flag is set. It introduce
> possible unnecessary instructions.

Your patch is white space damaged, it makes it hard to read and
impossible to apply.

Note that blk_queue_bounce_limit() is an initialization function, so not
much gained from optimizing on that.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/