linux-kernel - Re: [PATCH -mm 8/8] user ns: implement user ns unshare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Jan 2007 17:23:35 -0500
From:	Valdis.Kletnieks@...edu
To:	Frederik Deweerdt <deweerdt@...e.fr>
Cc:	"Serge E. Hallyn" <serue@...ibm.com>,
	Andrew Morton <akpm@...l.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm 8/8] user ns: implement user ns unshare

On Thu, 04 Jan 2007 19:07:00 GMT, Frederik Deweerdt said:
> On Thu, Jan 04, 2007 at 12:13:10PM -0600, Serge E. Hallyn wrote:
> > From: Serge E. Hallyn <serue@...ibm.com>
> > Subject: [PATCH -mm 8/8] user ns: implement user ns unshare
> > 
> > Implement CLONE_NEWUSER flag useable at clone/unshare.
> > 
> > Signed-off-by: Serge E. Hallyn <serue@...ibm.com>
> > ---
>   
> >  int copy_user_ns(int flags, struct task_struct *tsk)
> >  {
> > -	struct user_namespace *old_ns = tsk->nsproxy->user_ns;
> > +	struct user_namespace *new_ns, *old_ns = tsk->nsproxy->user_ns;
> >  	int err = 0;
>         ^^^^^^^^^^^^
> The "= 0" is superfluous here.

Umm?  bss gets cleared automagically, but when did we start auto-zeroing
the stack?

Content of type "application/pgp-signature" skipped