linux-kernel - Re: [PATCH -mm 8/8] user ns: implement user ns unshare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070104225253.GA3087@sergelap.austin.ibm.com>
Date:	Thu, 4 Jan 2007 16:52:53 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Valdis.Kletnieks@...edu
Cc:	Frederik Deweerdt <deweerdt@...e.fr>,
	"Serge E. Hallyn" <serue@...ibm.com>,
	Andrew Morton <akpm@...l.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm 8/8] user ns: implement user ns unshare

Quoting Valdis.Kletnieks@...edu (Valdis.Kletnieks@...edu):
> On Thu, 04 Jan 2007 19:07:00 GMT, Frederik Deweerdt said:
> > On Thu, Jan 04, 2007 at 12:13:10PM -0600, Serge E. Hallyn wrote:
> > > From: Serge E. Hallyn <serue@...ibm.com>
> > > Subject: [PATCH -mm 8/8] user ns: implement user ns unshare
> > >
> > > Implement CLONE_NEWUSER flag useable at clone/unshare.
> > >
> > > Signed-off-by: Serge E. Hallyn <serue@...ibm.com>
> > > ---
> >
> > >  int copy_user_ns(int flags, struct task_struct *tsk)
> > >  {
> > > -	struct user_namespace *old_ns = tsk->nsproxy->user_ns;
> > > +	struct user_namespace *new_ns, *old_ns = tsk->nsproxy->user_ns;
> > >  	int err = 0;
> >         ^^^^^^^^^^^^
> > The "= 0" is superfluous here.
> 
> Umm?  bss gets cleared automagically, but when did we start auto-zeroing
> the stack?

No, no, that's what i thought he meant at first too, but I actually
manually set err on all paths anyway  :)

-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/