linux-kernel - Re: [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020701050239q290849eahd3fc90af2c611d3@mail.gmail.com>
Date:	Fri, 5 Jan 2007 12:39:08 +0200
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	"Ahmed S. Darwish" <darwish.07@...il.com>,
	"Rolf Eike Beer" <eike-kernel@...tec.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts

On 1/5/07, Robert P. J. Day <rpjday@...dspring.com> wrote:
> in this case, as mr. beer suggests, you should also check if this
> represents a kmalloc->kzalloc cleanup (there's lots of those), and
> also see if you can replace one of these:
>
>   sizeof(struct blah)
>
> with one of these:
>
>   sizeof(*blahptr)
>
> according to the CodingStyle guide.

Unfortunately, not all maintainers like sizeof() changes, so you're
better off leaving them as-is.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/