linux-kernel - Re: [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070105105113.120d72c9@localhost.localdomain>
Date:	Fri, 5 Jan 2007 10:51:13 +0000
From:	Alan <alan@...rguk.ukuu.org.uk>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	"Ahmed S. Darwish" <darwish.07@...il.com>,
	Rolf Eike Beer <eike-kernel@...tec.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts

> represents a kmalloc->kzalloc cleanup (there's lots of those), and
> also see if you can replace one of these:
> 
>   sizeof(struct blah)
> 
> with one of these:
> 
>   sizeof(*blahptr)

Patches that do this will get rejected by the tty maintainer in favour of
the clarity of the sizeof(struct xyz) format 8)

Ahmed - if you can send me a patch for the tty_io/tty_ioctl code which
switches to kzalloc where it makes sense and removes un-needed casts I'll
review it and push the bits that look sane upstream. 

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/