linux-kernel - Re: [PATCH] Common compat_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070108104347.83a004aa.sfr@canb.auug.org.au>
Date:	Mon, 8 Jan 2007 10:43:47 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Kyle McMartin <kyle@...isc-linux.org>
Cc:	Christoph Hellwig <hch@...radead.org>, akpm@...l.org,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	parisc-linux@...ts.parisc-linux.org
Subject: Re: [PATCH] Common compat_sys_sysinfo (v2)

Hi Kyle,

Looks good.  Just one nit and one comment.

On Sun, 7 Jan 2007 10:40:45 -0500 Kyle McMartin <kyle@...isc-linux.org> wrote:
>
> diff --git a/kernel/compat.c b/kernel/compat.c
> index 6952dd0..cebb4c2 100644
> --- a/kernel/compat.c
> +++ b/kernel/compat.c
 .
 .
 .
> +	    __put_user (s.uptime, &info->uptime) ||
                      ^
We don't put spaces in here ...

> +asmlinkage long sys_sysinfo(struct sysinfo __user *info)
> +{
> +	struct sysinfo val;
> +
> +	do_sysinfo(&val);
>
> - out:
>  	if (copy_to_user(info, &val, sizeof(struct sysinfo)))
>  		return -EFAULT;

People have complined before that this adds a whole stack frame to the
"normal" syscall path.  Personally I don't care, but it has been
mentioned.

--
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped