linux-kernel - Re: [PATCH] Common compat_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200701080654.27100.arnd@arndb.de>
Date:	Mon, 8 Jan 2007 06:54:26 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Kyle McMartin <kyle@...isc-linux.org>,
	Christoph Hellwig <hch@...radead.org>, akpm@...l.org,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	parisc-linux@...ts.parisc-linux.org
Subject: Re: [PATCH] Common compat_sys_sysinfo (v2)

On Monday 08 January 2007 00:43, Stephen Rothwell wrote:
> > +asmlinkage long sys_sysinfo(struct sysinfo __user *info)
> > +{
> > +     struct sysinfo val;
> > +
> > +     do_sysinfo(&val);
> >
> > - out:
> >       if (copy_to_user(info, &val, sizeof(struct sysinfo)))
> >               return -EFAULT;
> 
> People have complined before that this adds a whole stack frame to the
> "normal" syscall path.  Personally I don't care, but it has been
> mentioned.

It might be a concern for something like 'read' which is called frequently
and in strange ways, but for 'sysinfo' this really should not matter.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/