linux-kernel - Re: [PATCH -rt] scheduling while atomic in remove_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1168258802.6235.18.camel@twins>
Date:	Mon, 08 Jan 2007 13:20:02 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -rt] scheduling while atomic in remove_proc_entry()

On Fri, 2006-12-29 at 13:12 -0800, Daniel Walker wrote:

> 
> Signed-Off-By: Daniel Walker <dwalker@...sta.com>
> 
> ---
>  fs/proc/generic.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6.19/fs/proc/generic.c
> ===================================================================
> --- linux-2.6.19.orig/fs/proc/generic.c
> +++ linux-2.6.19/fs/proc/generic.c
> @@ -555,7 +555,6 @@ static void proc_kill_inodes(struct proc
>  	/*
>  	 * Actually it's a partial revoke().
>  	 */
> -	filevec_add_drain_all();
>  	lock_list_for_each_entry(filp, &sb->s_files, f_u.fu_llist) {
>  		struct dentry * dentry = filp->f_path.dentry;
>  		struct inode * inode;
> @@ -738,6 +737,8 @@ void remove_proc_entry(const char *name,
>  		break;
>  	}
>  	spin_unlock(&proc_subdir_lock);
> +
> +	filevec_add_drain_all();
>  out:
>  	return;
>  }

Well, no. Draining after the inspect 'all' loop doesn't make sense, but
looking at 2.6.20-rc3-rt0 remove_proc_entry() looks sane.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/