linux-kernel - [PATCH] scsi_scan message cosmetic error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070109012854.GV18689@tpkurt.garloff.de>
Date:	Tue, 9 Jan 2007 02:28:54 +0100
From:	Kurt Garloff <kurt@...loff.de>
To:	Linux kernel list <linux-kernel@...r.kernel.org>,
	Linux SCSI list <linux-scsi@...r.kernel.org>
Subject: [PATCH] scsi_scan message cosmetic error

Hi,

Minor typo ... 
In my first iteration of patches (that got merged), the
BLIST_ATTACH_PQ3 actually had the value 0x800000, but that
got changed later to avoid conflicts. This piece must have
been overlooked.
You could obviously do something like %x and then add the
bitflags, but that looks overkill for something that does
not tend to change.

Please merge.
(Patch applied against latest 2.6.20rc version that I tested.)

From: Kurt Garloff <kurt@...loff.de>
Subject: [SCSI SCAN] Fix logging message for PQ3 devices

The blacklist flags BLIST_ATTACH_PQ3 has value 0x1000000,
not 0x800000.

Signed-off-by: Kurt Garloff <garloff@...e.de>

Index: linux-2.6.16-SLES10_SP1_BRANCH/drivers/scsi/scsi_scan.c
===================================================================
--- linux-2.6.16-SLES10_SP1_BRANCH.orig/drivers/scsi/scsi_scan.c
+++ linux-2.6.16-SLES10_SP1_BRANCH/drivers/scsi/scsi_scan.c
@@ -941,9 +941,9 @@ static int scsi_probe_and_add_lun(struct
 				unsigned char mod[17];
 
 				sdev_printk(KERN_INFO, sdev,
 					"scsi scan: consider passing scsi_mod."
-					"dev_flags=%s:%s:0x240 or 0x800240\n",
+					"dev_flags=%s:%s:0x240 or 0x1000240\n",
 					scsi_inq_str(vend, result, 8, 16),
 					scsi_inq_str(mod, result, 16, 32));
 			});
 		}
-- 
Kurt Garloff                   <kurt@...loff.de>             [Koeln, DE]
Physics:Plasma modeling <garloff@...simo.phys.tue.nl> [TU Eindhoven, NL]
Linux: Head Architect          <garloff@...e.de>            [Novell Inc]

Content of type "application/pgp-signature" skipped