linux-kernel - Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45A80213.5060401@redhat.com>
Date:	Fri, 12 Jan 2007 15:48:03 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	Alex Tomas <alex@...sterfs.com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and
 unlink race

Alex Tomas wrote:
>>>>>> Eric Sandeen (ES) writes:
> 
>  ES> so I think it's possible that link can sneak in there & find it after
>  ES> the mutex is dropped...?  Is this ok? :)  It's certainly -happening-
>  ES> anyway....
> 
> yes, but it shouldn't allow to re-link such inode back, IMHO.
> a filesystem may start some non-revertable activity in its
> unlink method.
> 
> thanks, Alex

I tend to agree, chatting w/ Al I think he does too.  :)  I'll test
a patch that kicks out ext3_link() with -ENOENT at the top, and resubmit
that if things go well.

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/