linux-kernel - Re: Fwd: [PATCH] Fix some ARM builds due to HID brokenness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Jan 2007 21:53:51 +0000
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Andrew Morton <akpm@...l.org>,
	Linux Kernel List <linux-kernel@...r.kernel.org>,
	jkosina@...e.cz, linux-input@...ey.karlin.mff.cuni.cz,
	Adrian Bunk <bunk@...sta.de>
Subject: Re: Fwd: [PATCH] Fix some ARM builds due to HID brokenness

On Fri, Jan 12, 2007 at 09:42:16PM +0000, Russell King wrote:
> On Fri, Jan 12, 2007 at 09:00:15PM +0000, Russell King wrote:
> > Could we please have this (or a proper fix) in before 2.6.20 to resolve
> > the regression please?
> 
> Actually, this remaining regression is not caused by this patch not being
> integrated, but this:
> 
> config USB_HID
>         tristate "USB Human Interface Device (full HID) support"
>         default y
>         depends on USB
>         select HID
> 
> So... we have USB_HID _newly_ selected in configurations which didn't
> have it before, which overrides CONFIG_HID and builds HID without
> input support.
> 
> Relevant lines from "make ep93xx_defconfig" output:
> 
> Generic input layer (needed for keyboard, mouse, ...) (INPUT) [N/m/y/?] n
> Support for Host-side USB (USB) [Y/n/m/?] y
> USB Human Interface Device (full HID) support (USB_HID) [Y/n/m/?] (NEW) y
> 
> Can USB_HID also depend on INPUT ?

Nevertheless, here's a patch to solve more of the same that my original
patch attempted to solve.  The original patch is still required.  Seems
to solve the final instance of this problem here.

diff --git a/drivers/usb/input/Kconfig b/drivers/usb/input/Kconfig
index 258a5d0..c7d8875 100644
--- a/drivers/usb/input/Kconfig
+++ b/drivers/usb/input/Kconfig
@@ -7,7 +7,7 @@ comment "USB Input Devices"
 config USB_HID
 	tristate "USB Human Interface Device (full HID) support"
 	default y
-	depends on USB
+	depends on USB && INPUT
 	select HID
 	---help---
 	  Say Y here if you want full HID support to connect USB keyboards,


-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/