linux-kernel - Re: [PATCH 45/59] sysctl: C99 convert ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Jan 2007 23:15:43 +0100
From:	Ingo Oeser <ioe-lkml@...eria.de>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	"<Andrew Morton" <akpm@...l.org>, linux-kernel@...r.kernel.org,
	containers@...ts.osdl.org, netdev@...r.kernel.org,
	xfs-masters@....sgi.com, xfs@....sgi.com,
	linux-scsi@...r.kernel.org, James.Bottomley@...eleye.com,
	minyard@....org, openipmi-developer@...ts.sourceforge.net,
	tony.luck@...el.com, linux-mips@...ux-mips.org,
	ralf@...ux-mips.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, linux390@...ibm.com,
	linux-390@...marist.edu, paulus@...ba.org, linuxppc-dev@...abs.org,
	lethal@...ux-sh.org, linuxsh-shmedia-dev@...ts.sourceforge.net,
	ak@...e.de, vojtech@...e.cz, clemens@...isch.de,
	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-parport@...ts.infradead.org, andrea@...e.de,
	tim@...erelk.net, philb@....org, aharkes@...cmu.edu,
	coda@...cmu.edu, codalist@...emann.coda.cs.cmu.edu,
	aia21@...tab.net, linux-ntfs-dev@...ts.sourceforge.net,
	mark.fasheh@...cle.com, kurt.hackel@...cle.com
Subject: Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c

Hi Eric,

On Tuesday, 16. January 2007 17:39, Eric W. Biederman wrote:
> diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c
> index 2e744a2..5337789 100644
> --- a/drivers/parport/procfs.c
> +++ b/drivers/parport/procfs.c
> @@ -263,50 +263,118 @@ struct parport_sysctl_table {
> +		{
> +			.ctl_name	= DEV_PARPORT_BASE_ADDR,
> +			.procname	= "base-addr",
> +			.data		= NULL,
> +			.maxlen		= 0,
> +			.mode		= 0444,
> +			.proc_handler	= &do_hardware_base_addr
> +		},

No need to initialize to zero or NULL. Just list any variable, which is NOT zero or NULL.

> +		{
> +			.ctl_name	= DEV_PARPORT_AUTOPROBE + 1,
> +			.procname	= "autoprobe0",
> +			.data		= NULL,
> +			.maxlen		= 0,
> +			.maxlen		= 0444,
> +			.proc_handler	=  &do_autoprobe
> +		},

Typo here? .mode = 0444 makes mor sense.

Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/