linux-kernel - Re: [PATCH 2.6.20-rc5 4/4] sys_futex64 : allows 64bit futexes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070118223442.GB5404@infradead.org>
Date:	Thu, 18 Jan 2007 22:34:42 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Pierre Peiffer <pierre.peiffer@...l.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Ulrich Drepper <drepper@...hat.com>,
	Jakub Jelinek <jakub@...hat.com>,
	Jean-Pierre Dion <jean-pierre.dion@...l.net>
Subject: Re: [PATCH 2.6.20-rc5 4/4] sys_futex64 : allows 64bit futexes

On Thu, Jan 18, 2007 at 08:45:56AM +0100, Ingo Molnar wrote:
> include/asm-i386/futex.h:
> 
>                 switch (cmp) {
>                 case FUTEX_OP_CMP_EQ: ret = (oldval == cmparg); break;
>                 case FUTEX_OP_CMP_NE: ret = (oldval != cmparg); break;
>                 case FUTEX_OP_CMP_LT: ret = (oldval < cmparg); break;
>                 case FUTEX_OP_CMP_GE: ret = (oldval >= cmparg); break;
>                 case FUTEX_OP_CMP_LE: ret = (oldval <= cmparg); break;
>                 case FUTEX_OP_CMP_GT: ret = (oldval > cmparg); break;
>                 default: ret = -ENOSYS;
>                 }
> 
> Pierre correctly matched the existing style.

Old code doing things wrong is no excuse for new code doing the same
mistake.  Much better send a patch to fix up the previous unreadable
mess aswell.  Then again some indentation fixups won't help that much
to make futrsx not the totally unreadable spaghetti code it's now ;-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/